Packages: Replace is-plain-obj with is-plain-object - #43511
Merged
Conversation
tyxla
added
npm Packages
tyxla
marked this pull request as ready for review
August 23, 2022 10:41
tyxla
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
August 23, 2022 10:41
Member
npm publishing will trigger tomorrow together with the Gutenberg plugin release 😄 |
Member
|
Let's also remove the workaround from the Jest config and we should be done: |
Member
Author
But we're already removing it: Or are you referring to something else? |
|
Size Change: +379 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Member
Sorry about it. I missed that line 💯 Any idea why Jest is having issues with importing the new package? |
Member
Author
I think it's because the dependency is missing in |
Member
it's a development dependency, so it should be defined in the top-level |
gziolo
reviewed
Aug 23, 2022
anomiex
reviewed
Aug 23, 2022
anomiex
reviewed
Aug 23, 2022
Contributor
|
Thanks for the change! Just a heads up, adding in |
Member
Author
|
Thanks for letting us know, and please do let me know if you encounter any similar issues in the future. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In this PR we're replacing
is-plain-objwithis-plain-object.Fixes #43434.
Why?
Because the former is ESM-only and this causes problems in CommonJS environments.
Prior attempts to address this were inconclusive: #43179 and #43271.
How?
Just replacing the package everywhere, they're basically drop-in replacements.
@gziolo we'll need to prepare some new package releases once this lands.
Testing Instructions