Add temporary workaround to fix broken common js import of mini-css-extract-plugin - #38004
Merged
Conversation
|
Size Change: +54 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Member
|
Thank you for acting so quickly! I commented on the issue here: #37992 (comment). Let’s if it gets fixed upstream first. In the meantime, can you check why |
|
Untested: would be something like this even more stable in case it changes again in the future?
|
Member
Author
|
@leanderseige that is a great idea 👍 Added it :) |
|
What can we do to get this PR merged? @fabiankaegy It seems like the only "required" failing check fails because of changes on package-lock.json. Is it really necessary to modify this file in this PR? |
gziolo
approved these changes
Jan 17, 2022
gziolo
left a comment
gziolo
left a comment
Member
There was a problem hiding this comment.
There is still no new version published for mini-css-extract-plugin so let's get this one in to resolve the issue.
gziolo
added a commit
that referenced
this pull request
Jan 17, 2022
…xtract-plugin (#38004) * update mini-css-extract-plugin to version 2.5.0 * fix add temporary workarround for mini-css-extract-plugin * fix cover both types of import * Save changes applied to the npm lock file * Add changelog entry * Improve comments * Update CHANGELOG.md Co-authored-by: Grzegorz Ziolkowski <grzegorz@gziolo.pl>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the version of the
mini-css-extract-pluginto 2.5.0 which is loaded by default anyways. There is an issue in version 2.5.0 that breaks common js imports that can be worked around by adding.defaultto the end of therequirestatement.Closing #37992
How has this been tested?
Locally using wp-scripts
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).