Scripts: Add .prettierignore, use in format script - #30844
Merged
Conversation
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
ockham
force-pushed
the
add/prettierignore
branch
from
April 14, 2021 17:17
985fe03 to
d4afc4d
Compare
gziolo
self-requested a review
April 15, 2021 08:45
Member
It used this file before https://github.com/WordPress/gutenberg/blob/trunk/.eslintignore. |
Contributor
Author
Ah thanks, seems like I didn't check for the obvious 😅 I guess I'll have to add a root-level |
ockham
marked this pull request as ready for review
April 15, 2021 10:05
gziolo
reviewed
Apr 15, 2021
Member
|
It would be great to add a small note in the README file that Prettier is used internally and the list of ignored files can be modified by using https://github.com/WordPress/gutenberg/tree/trunk/packages/scripts#format Plus a short note in the CHANGELOG for New Features: |
gziolo
approved these changes
Apr 19, 2021
This reverts commit d4afc4d.
ockham
force-pushed
the
add/prettierignore
branch
from
April 23, 2021 12:39
10a6e42 to
47688d6
Compare
Member
|
🎉 |
sirreal
reviewed
Jun 14, 2024
| build-module | ||
| build-types | ||
| packages/block-serialization-spec-parser/parser.js | ||
| packages/e2e-tests/plugins |
Member
There was a problem hiding this comment.
Do you know why this was necessary? There's JavaScript there that seems like it should be formatted. I'll create a PR to remove this and see what happens.
Member
There was a problem hiding this comment.
There are some test plugins with JS code that not necessarily are compatible with the linting rules established for Gutenberg plugin. Feel free to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #30240 (comment).
Curiously, this causes a number of files in theEdit: Forgot to add a root-levele2e-testspackage to be formatted slightly differently than before. We'll need to find out why that is.prettierignore.Thanks @gziolo for pointing that out!How has this been tested?