Build: Ensure non-JS changes are processed in the watch mode - #30343
Merged
Conversation
gziolo
requested review from
a team,
jasmussen,
kevin940726,
noisysocks and
youknowriad
March 29, 2021 12:09
gziolo
force-pushed
the
fix/webpack-copy-non-js
branch
from
March 29, 2021 12:12
6a38132 to
b2206ff
Compare
Contributor
|
This is really nice work, thank you. I can confirm that the CSS consistently compiles for me, when on this branch. Specifically I did first and sure enough, red borders everywhere. Removing it again, gone. I'll let others sanity check the code, but thank you, this is quality of life 👌 |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
gziolo
changed the title
youknowriad
approved these changes
Mar 29, 2021
youknowriad
left a comment
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
Thank you. Let's keep an eye on the upcoming days on whether the "watch" target change is impactful.
youknowriad
reviewed
Mar 29, 2021
| ].filter( Boolean ), | ||
| watchOptions: { | ||
| ignored: '!packages/*/!(src)/**/*', | ||
| ignored: '!packages/*/build-module/**/*', |
Contributor
There was a problem hiding this comment.
Actually, this is going to watch everything expect the build-module folder which is the opposite of what we want it seems :P (the key is ignored)
Member
Author
There was a problem hiding this comment.
It's a double negation, we tell ignore everything that isn't in the build-module with ! character 🙃
The API for watchOptions is very simple and doesn't provide the allowed list.
Contributor
There was a problem hiding this comment.
oh didn't see that ! there
Member
Author
There was a problem hiding this comment.
We will need RegExp to make it work with the PostCSS upgrade, it's even more fun:
ignored: /^(?!.*\/packages\/.*\/build-module\/.*)$/,
youknowriad
approved these changes
Mar 29, 2021
Member
Author
|
I'm including also a screencast to show that it works. There is a slight delay but I assume it's how long webpack processes the files: Screen.Recording.2021-03-29.at.14.39.24.mov |
Contributor
|
What a rollercoaster! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally reported by @stokesman in #27821 (comment) after merging #27821 (it was reverted because of the issue reported).
A similar issue was previously reported and this PR should also fix #22645.
In addition to that, there were several reports that changes to SCSS files weren't propagate when using
npm run dev(build in watch mode).Changes proposed
This PR upgrades the version of
CopyWebpackPluginto5.1.2(there are newer versions that work only with webpack 5) and updates the list of ignored files in the watch mode to resolve both issues present.Now that
CopyWebpackPluginensures we watch for changes for all files that it processes, we only need to look at changes applied to the packages inbuild-modulefolder (all production packages are transpiled and have this folder).How has this been tested?
Run
npm run devand make sure that changes to files are reflected in the/buildfolder. I tried changing the following files:packages/*/src/folderblock.jsonin theblock-librarypackageTypes of changes
Bug fix (non-breaking change which fixes an issue).
Checklist:
*.native.jsfiles for terms that need renaming or removal).