Scripts: Allow CSS modules in the build commands

[cpiber]

Description

@wordpress/scripts modified config to allow css modules (and extract them like style.css)

Checklist:

• My code is tested.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cpiber! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[gziolo]

Hi @cpiber. Thank you for your contribution. Can you provide more details for the proposed change?

• What issue is it trying to solve?
• How it can be tested?
• How it should be documented?

[cpiber]

• It allows for using css modules. The webpack plugin css-loader already supports that.
• I'm not sure how you usually set webpack configurations. The changes I made will compile .*.module.(sa|sc|c)ss files with css modules enabled. They also extract style(.module)?.(sc|sa|c)ss files (so module files as well).
• In the readme there is the "Using CSS" section, possibly mention the use of css-modules there as well.

[gziolo]

In the readme there is the "Using CSS" section, possibly mention the use of css-modules there as well.

That would be a great addition with an example of the file and its content maybe? There is already a section with CSS:
https://github.com/WordPress/gutenberg/tree/trunk/packages/scripts#using-css

I guess once we have documentation. It only needs to be tested and we are good to go. Thank you for your contribution 🙇🏻

[cpiber]

To clarify, do you want me to edit the README?

[gziolo]

To clarify, do you want me to edit the README?

Yes, that would be helpful for folks using wp-scripts.

A section New Feature in the changelog would also help with discovery:

https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md

[gziolo]

It looks like you merged your branch with the upstream master branch. It was renamed to trunk so that would explain why there are additional 400+ commits in your PR 😄

[cpiber]

I rebased on trunk, yes

[gziolo]

I'm not sure what went wrong but there should be only your changes listed in this PR. You can try following this documentation and see if it helps:
https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/git-workflow.md#keeping-your-fork-up-to-date

[cpiber]

I used rebase instead of merge, maybe that was a problem? Should I go back to an earlier commit and try with merge again?

[gziolo]

You can also cherry-pick your commits to a fresh branch if that helps. Whatever makes it work and I can merge your changes 😄

[cpiber]

Alright, I went back to the old master and did a merge instead of a rebase, I hope it's okay now

[gziolo]

Thank you for your contribution. This looks good to go 🎉

[github-actions]

Congratulations on your first merged pull request, @cpiber! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!