Create Block: Fix issue with processing unrelated engines - #29066
Merged
Conversation
gziolo
requested review from
ajitbohra,
mkaz,
nerrad and
ntwb
as code owners
February 17, 2021 09:03
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
…son` file of the current project
gziolo
force-pushed
the
fix/check-engines-yarn
branch
from
February 17, 2021 09:23
9f93c3d to
98a705b
Compare
gziolo
added
[Tool] WP Scripts
gwwar
approved these changes
Feb 18, 2021
gwwar
left a comment
gwwar
left a comment
Contributor
There was a problem hiding this comment.
Nice sleuthing! Changes here look reasonable to me. I also did a smoke test by running check-engines
This was referenced Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #28965 (comment):
This change should prevent the issue that @raaaahman had in #28965:
Changes
@wordpress/create-blockcheck-node-versionto version^4.1.0that no longer processes unrelated engines@wordpress/scriptscheck-enginescommand to theenginesconfig inpackage.jsonfile of the current project.check-node-versionto version^4.1.0that no longer processes unrelated engines withcheck-enginescommand.How has this been tested?
npx wp-scripts check-enginesshould still workI also updated
enginesin thepackage.jsonfile in the Gutenberg project to see that the command errors when requirements are not met.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: