Add eslint rules to guard against unexpected imports/exports - #28513
Merged
Conversation
kevin940726
added
[Type] Bug
kevin940726
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
gziolo,
nerrad and
ntwb
as code owners
January 27, 2021 09:13
kevin940726
force-pushed
the
update/add-eslint-plugin-import
branch
from
January 27, 2021 09:20
b3d4f27 to
0536de7
Compare
|
Size Change: 0 B Total Size: 1.37 MB
ℹ️ View Unchanged
|
kevin940726
marked this pull request as draft
January 27, 2021 09:36
Member
|
Great idea to add those rules. I see there are several violations to fix first, though. If you want to add it to the ESLint plugin with WordPress configs, I would recommend starting with the warning level to not fail their CI checks after a minor update of dependencies. This is a common strategy that other ESLint plugins use to roll out more strict checks gradually. Even looking at Gutenberg changes necessary to satisfy linter - it's a breaking change. The approach we used in the past was marking new rules at warning level in the package and promote to an error in the Gutenberg repo. |
Member
Author
|
@gziolo That's an excellent idea! Will try! |
kevin940726
force-pushed
the
update/add-eslint-plugin-import
branch
from
January 29, 2021 02:09
0946c12 to
1ec8e2d
Compare
kevin940726
marked this pull request as ready for review
January 29, 2021 02:58
gziolo
reviewed
Jan 29, 2021
gziolo
left a comment
gziolo
left a comment
Member
There was a problem hiding this comment.
Everything looks great as it goes for the ESLint changes.
There is some usual dance left with rebases and the package lock file.
gziolo
approved these changes
Feb 1, 2021
gziolo
left a comment
gziolo
left a comment
Member
There was a problem hiding this comment.
Nice work, thank you for wrangling it 💯
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #28510.
Add
eslint-plugin-importand enable theimport/defaultandimport/namedrules.A typo is introduced in #28176, after briefly discussed on Slack, I think it's best to update the linter to guard against these kinds of bugs.
This PR also fixes the errors found by the linter.
How has this been tested?
Only apply the first commit of this PR and run the linter:
Observe that there're errors reported.
After applying all the changes, run the linter again, observe that there're no more errors.
Types of changes
Bug fix
Checklist: