Mirror WordPress plugin install text for blocks - #25084
Merged
Merged
Conversation
ryelle
added
the
[Feature] Block Directory
ryelle
self-requested a review
September 4, 2020 22:42
Member
Author
|
Hi @ryelle ! Have you had a chance to look at this? I'd appreciate your input :) |
ryelle
approved these changes
Sep 9, 2020
ryelle
left a comment
ryelle
left a comment
Contributor
There was a problem hiding this comment.
Looks good! and thanks for the tests, since there are no blocks yet with over a million installations 🙂
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #24842 —I've modified the text to mirror the implementation of the plugin installations count text from WordPress.
Something to consider is that
number_format_i18nis not implemented yet for Gutenberg.(#22628)How has this been tested?
Added tests for each variation.
Screenshots
Types of changes
Checklist: