Skip to content

Scripts: Exclude node_modules from source map processing in start script #23711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 2 commits into from
Jul 6, 2020
Merged

Scripts: Exclude node_modules from source map processing in start script #23711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf82905
Scripts: Exclude node_modules from source map processing in build scr…
gziolo Jul 6, 2020
b93c82b
Docs: Add note in @wordpress/scripts changelog about fix
gziolo Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/scripts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Allow the CSS, SVG, and Sass loaders to process files from node_modules directory.
- Improve the way licenses are validated with `check-licenses` by falling back to license files verification when the entry in `package.json` doesn't contain an allowed match ([#23550](https://github.com/WordPress/gutenberg/pull/23550)).
- Fix `build` script error when importing `style.css` files ([#23710](https://github.com/WordPress/gutenberg/pull/23710)).
- Exclude `node_modules` from source map processing in `start` script ([#23711](https://github.com/WordPress/gutenberg/pull/23711)).

## 12.0.0-rc.0 (2020-06-24)

Expand Down
1 change: 1 addition & 0 deletions packages/scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ if ( ! isProduction ) {
config.devtool = process.env.WP_DEVTOOL || 'source-map';
config.module.rules.unshift( {
test: /\.js$/,
exclude: [ /node_modules/ ],

@youknowriad youknowriad Jul 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended? Just want to make sure we have a way to debug wordpress packages on Core. (not sure this has an impact though, Core might not use wordpress/scripts yet)

@gziolo gziolo Jul 7, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is completely separate process in WP Core, even when we use @wordpress/scripts we will use a custom webpack config. It shouldn’t have an impact.

use: require.resolve( 'source-map-loader' ),
enforce: 'pre',
} );
Expand Down