Vendor WASI WITs in this repository - #722
Merged
Merged
Conversation
I've been trying to dance around doing this and only download WITs at compile time as necessary, but given current integration problems into wasi-sdk I think it's time to just go ahead and vendor the WITs in this repository. The current problem is that the WIT vendoring tool, `wkg`, does not run in the very-old-Linux-container used to build wasi-sdk. The reason WITs are needed are for the `wasm-tools component embed` command to embed type information in startup object files. With this PR the dependency between this embedding and the WIT download process is severed and no longer needed. WITs are vendored much the same way generated bindings are done where the files are present in repo but are checked in CI that they are up-to-date. This means that the files are continuously checked to represent their pristine copies.
pchickey
approved these changes
Jan 29, 2026
alexcrichton
added a commit
to alexcrichton/wasi-libc
that referenced
this pull request
Jan 29, 2026
Forgotten from WebAssembly#722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been trying to dance around doing this and only download WITs at compile time as necessary, but given current integration problems into wasi-sdk I think it's time to just go ahead and vendor the WITs in this repository. The current problem is that the WIT vendoring tool,
wkg, does not run in the very-old-Linux-container used to build wasi-sdk. The reason WITs are needed are for thewasm-tools component embedcommand to embed type information in startup object files.With this PR the dependency between this embedding and the WIT download process is severed and no longer needed. WITs are vendored much the same way generated bindings are done where the files are present in repo but are checked in CI that they are up-to-date. This means that the files are continuously checked to represent their pristine copies.