Temporarily disable the use of __heap_base. - #132
Merged
Conversation
peterhuene
approved these changes
Nov 7, 2019
This temporarily disables the feature in a214f1c, since it hits LLVM bug 43613, which is fixed on LLVM master and awaiting a backport to the 9.0 branch. https://bugs.llvm.org/show_bug.cgi?id=43613
sunfishcode
force-pushed
the
workaround-heap-base
branch
from
November 7, 2019 19:25
e321150 to
ab9b6de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#114, which we just merged, unfortunately hits an LLVM bug, which is fixed on LLVM master, but not yet in LLVM 9.0. Disable the feature for now to unbreak the tree with LLVM 9.0.
This temporarily disables the feature in
a214f1c, since it hits LLVM bug
43613, which is fixed on LLVM master and awaiting a backport to
the 9.0 branch.
https://bugs.llvm.org/show_bug.cgi?id=43613