[codex] Add native Windows shell support#41
Draft
yurilopes wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR improves DevSpace shell execution on Windows while preserving the existing Bash behavior for Linux, macOS, and users who explicitly opt into Bash.
DEVSPACE_SHELL=auto|bash|powershell|cmd.cmd.exesupport viaDEVSPACE_SHELL=cmd.DEVSPACE_SHELL=bashand non-Windows defaults.-matchusage with raw Windows path literals, including literals assigned to variables and then passed to-match.devspace doctor, MCP tool guidance, docs, and tests.Why
When ChatGPT generated PowerShell commands through the previous Bash-backed shell, Bash/MSYS could expand PowerShell syntax such as
$_.CommandLinebefore PowerShell received it. Native PowerShell execution fixes that transport issue.A second common failure mode remained: using PowerShell
-matchfor literal Windows path fragments.-matchis regex-based, so path fragments like\profilescan trigger malformed regex escapes such as\p. The new guardrail blocks the fragile pattern and tells the model to use.Contains(),-like, or[regex]::Escape().Impact
Windows users can run DevSpace with native PowerShell by default. Existing Bash workflows remain available with
DEVSPACE_SHELL=bash, and Linux/macOS behavior stays on the existing Bash backend.Validation
npm testnpm run typechecknpm run buildgit diff --checkdevspace doctoron Windows confirmedShell mode: autoresolves to native PowerShell.