-
-
Notifications
You must be signed in to change notification settings - Fork 267
Improve doctor reachability diagnostics #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bowersjames
wants to merge
1
commit into
Waishnav:main
Choose a base branch
from
bowersjames:codex/doctor-reachability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import assert from "node:assert/strict"; | ||
| import { checkEndpoint } from "./health.js"; | ||
|
|
||
| assert.deepEqual( | ||
| await checkEndpoint("http://127.0.0.1:7676/healthz", async () => new Response("ok", { status: 200 })), | ||
| { ok: true, status: 200 }, | ||
| ); | ||
|
|
||
| assert.deepEqual( | ||
| await checkEndpoint("https://stale.example.com/healthz", async () => { | ||
| throw new TypeError("fetch failed"); | ||
| }), | ||
| { ok: false, error: "fetch failed" }, | ||
| ); | ||
|
|
||
| assert.deepEqual( | ||
| await checkEndpoint("https://example.com/healthz", async () => new Response("no", { status: 502 })), | ||
| { ok: false, status: 502, error: "HTTP 502" }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| export interface EndpointHealth { | ||
| ok: boolean; | ||
| status?: number; | ||
| error?: string; | ||
| } | ||
|
|
||
| type Fetch = (input: string, init?: RequestInit) => Promise<Response>; | ||
|
|
||
| export async function checkEndpoint( | ||
| url: string, | ||
| fetcher: Fetch = fetch, | ||
| ): Promise<EndpointHealth> { | ||
| try { | ||
| const response = await fetcher(url, { | ||
| signal: AbortSignal.timeout(5_000), | ||
| }); | ||
| if (!response.ok) { | ||
| return { | ||
| ok: false, | ||
| status: response.status, | ||
| error: `HTTP ${response.status}`, | ||
| }; | ||
| } | ||
|
|
||
| return { ok: true, status: response.status }; | ||
| } catch (error) { | ||
| return { | ||
| ok: false, | ||
| error: error instanceof Error ? error.message : String(error), | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| export function formatEndpointHealth(health: EndpointHealth): string { | ||
| return health.ok | ||
| ? `reachable (HTTP ${health.status})` | ||
| : `unreachable (${health.error ?? "unknown error"})`; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 2133
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 4458
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 4458
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 8335
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 8335
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 4600
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 4600
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 4600
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 1047
🏁 Script executed:
Repository: Waishnav/devspace
Length of output: 1047
Normalize the probe host before building local URLs.
HOST/files.config.hostis unrestricted (default127.0.0.1), solocalMcpUrlandlocalHealthUrlcan break for IPv6 literals like::1and can point at unusable bind-all addresses like0.0.0.0/::. Use a loopback address for probes and bracket IPv6 hosts, matchinglocalPublicBaseUrl().🤖 Prompt for AI Agents