Conversation
This was
linked to
issues
Jul 22, 2023
TonePoems
reviewed
Jul 24, 2023
TonePoems
left a comment
TonePoems
left a comment
Collaborator
There was a problem hiding this comment.
Is this the full PR? Doesnt look like the whole feature unless it got lost in the shuffle somewhere.
Author
|
For some reason, the revert pr removed only a partial amount of the code, I don’t know why it did that. So since some of the code is still in the master branch, this is all that needs to be merged. |
TonePoems
approved these changes
Jul 25, 2023
TonePoems
left a comment
TonePoems
left a comment
Collaborator
There was a problem hiding this comment.
Question answered, comfortable with the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #51 reverted some of the changes made by pull request #22 because it was merged without being approved. This pull request adds the remaining changes that #22 made again and now needs to be approved.