Keep stack frames that have no parameter list - #1865
Merged
Conversation
The scrubber trims each `at` frame at its closing paren, but not every frame has one: NativeAOT renders unresolved frames as `at MyApp!<BaseAddress>+0x1a2b3c`. Both IndexOf calls returned -1, so the slice kept zero characters and the frame became an empty line, or the literal `...)` with removeParams. Such frames are now emitted as they are, which also leaves the `+` of the offset alone rather than reading it as a nested type separator.
This was referenced Aug 26, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScrubStackTracetrims eachatframe at its closing paren, but not every frame has one. NativeAOT renders unresolved frames as:Both
IndexOfcalls return -1, sospan[..(indexOfRight + 1)]keeps zero characters and the frame becomes an empty line — or the literal...)underremoveParams. Captured onmain:Frames with no parameter list are now emitted as they are. That also leaves the
+in the offset alone — routing them throughWriteReplacePluswould have rewritten+0x1a2b3cto.0x1a2b3c, since that helper exists to turn the nested type separator into a dot.NoParensandNoParens_RemoveParamscover both paths, each mixing unresolved frames with a normal one.Verify.Tests(1301) passes.