Keep empty collections ignored alongside instance predicates - #1860
Merged
Conversation
TryGetScrubOrIgnoreByInstance returned as soon as it found predicates registered for the value's type and none of them matched, skipping the empty collection check below it. So an empty List<string> started rendering as [] merely because some unrelated IgnoreInstance or ScrubInstance predicate had been registered for that type. No predicate matching is not a decision to keep the value, so the empty collection check now runs either way. The test lives in its own file rather than being appended to SerializationTests, so this does not collide with the other pending fixes that append there.
SimonCropp
force-pushed
the
fix-ignoreinstance-empty-collections
branch
from
August 17, 2026 12:34
fed73d9 to
80fb845
Compare
This was referenced Aug 26, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryGetScrubOrIgnoreByInstancereturned as soon as it found predicates registered for the value's runtime type and none of them matched, which skipped theignoreEmptyCollectionscheck sitting below it.So registering any
IgnoreInstance<List<string>>orScrubInstance<List<string>>predicate — even one that never matches, and regardless of what it was for — quietly turned off empty-collection handling forList<string>, and empty ones started appearing as[].No predicate matching is not a decision to keep the value, so the empty collection check now runs whether or not predicates were registered for the type.
IgnoreInstanceTests.NonMatchingPredicateKeepsEmptyCollectionsIgnoredregisters a never-matching predicate and verifies an empty and a non-empty collection of that type. It fails onmain, where the empty one renders as[].The test is in its own file rather than appended to
SerializationTests, so it does not collide with #1859, which appends there. Verified: the two branches now merge clean, and the merged result passes (1301).Verify.Tests(1300) andStaticSettingsTestspass.