Simplify PageIndex API key config: remove pageindex_api_key_env#8
Closed
rejojer wants to merge 1 commit into
Closed
Simplify PageIndex API key config: remove pageindex_api_key_env#8rejojer wants to merge 1 commit into
rejojer wants to merge 1 commit into
Conversation
…config; update readme
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
KylinMountain
added a commit
that referenced
this pull request
May 31, 2026
Note wiki/entities/ holds named-thing pages (people/orgs/places/ products/works/events) with a type: frontmatter field, that index.md has a ## Entities section, and that 'who/what is X' questions should read the matching entities/ page first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageindex_api_key_envconfig option, hardcodePAGEINDEX_API_KEYenv var directlyopenkb initby removing one interactive promptpi_api_keytopageindex_api_keyfor clarityTest plan
pytest tests/test_config.pypassesopenkb initno longer prompts for PageIndex API key env varPAGEINDEX_API_KEYin.env