Skip to content

Simplify PageIndex API key config: remove pageindex_api_key_env#8

Closed
rejojer wants to merge 1 commit into
pre-pageindex-cleanupfrom
dev
Closed

Simplify PageIndex API key config: remove pageindex_api_key_env#8
rejojer wants to merge 1 commit into
pre-pageindex-cleanupfrom
dev

Conversation

@rejojer
Copy link
Copy Markdown
Member

@rejojer rejojer commented Apr 8, 2026

Summary

  • Remove pageindex_api_key_env config option, hardcode PAGEINDEX_API_KEY env var directly
  • Simplify openkb init by removing one interactive prompt
  • Rename pi_api_key to pageindex_api_key for clarity
  • Update README and config.yaml.example

Test plan

  • Verify pytest tests/test_config.py passes
  • Verify openkb init no longer prompts for PageIndex API key env var
  • Verify PageIndex Cloud still works with PAGEINDEX_API_KEY in .env

@rejojer
Copy link
Copy Markdown
Member Author

rejojer commented Apr 8, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@rejojer rejojer deleted the branch pre-pageindex-cleanup April 8, 2026 02:44
@rejojer rejojer closed this Apr 8, 2026
KylinMountain added a commit that referenced this pull request May 31, 2026
Note wiki/entities/ holds named-thing pages (people/orgs/places/
products/works/events) with a type: frontmatter field, that index.md
has a ## Entities section, and that 'who/what is X' questions should
read the matching entities/ page first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant