Include group context on failure output - #38
Merged
Conversation
If there is a call to `console.group` around a `log|warn|error` then it is being swallowed and so when tests fail the output of `console.group` is not emitted to the console. Include any group context in the `flushUnexpectedConsoleCalls` output so it can be debugged.
Contributor
Author
|
I made a slight mistake on my earlier PR in that it completely silenced any output from |
Owner
|
Thanks for the hotfix. I'll release it in around a hour. |
Owner
Contributor
Author
|
Fantastic. Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a call to
console.grouparound alog|warn|errorthen it is being swallowed and so when tests fail the output ofconsole.groupis not emitted to the console.Include any group context in the
flushUnexpectedConsoleCallsoutput so it can be debugged.