Fix browser elicitation resume page session lookup#1317
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 6e7a442 | Commit Preview URL Branch Preview URL |
Jul 04 2026, 09:36 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 6e7a442 | Jul 04 2026, 09:37 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud resume page looked up the MCP session Durable Object with
idFromString, while sessions are created with name-based ids (idFromName). So opening a browser-elicitation approval URL queried a DO that doesn't exist and the page showed "This paused execution is no longer available."The lookup in
apps/cloud/src/auth/handlers.tsnow goes through a new sharedmcpSessionStubhelper, and all other session-DO call sites were migrated to it. A new oxlint rule (executor/no-raw-durable-object-id) flags rawidFromName/idFromStringoutside the canonical helpers so addressing can't drift again.e2e coverage in
e2e/cloud/mcp-browser-resume-page.test.ts: an API-level scenario (red before the fix withMcpExecutionNotFoundError) and a browser scenario that loads the approval page and approves through the UI.Recording of the browser scenario: https://github.com/UsefulSoftwareCo/executor/blob/elicitation-resume-repro/e2e/recordings/mcp-browser-resume-page.mp4