Skip to content

Fix browser elicitation resume page session lookup#1317

Merged
RhysSullivan merged 6 commits into
mainfrom
elicitation-resume-repro
Jul 4, 2026
Merged

Fix browser elicitation resume page session lookup#1317
RhysSullivan merged 6 commits into
mainfrom
elicitation-resume-repro

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

The cloud resume page looked up the MCP session Durable Object with idFromString, while sessions are created with name-based ids (idFromName). So opening a browser-elicitation approval URL queried a DO that doesn't exist and the page showed "This paused execution is no longer available."

The lookup in apps/cloud/src/auth/handlers.ts now goes through a new shared mcpSessionStub helper, and all other session-DO call sites were migrated to it. A new oxlint rule (executor/no-raw-durable-object-id) flags raw idFromName/idFromString outside the canonical helpers so addressing can't drift again.

e2e coverage in e2e/cloud/mcp-browser-resume-page.test.ts: an API-level scenario (red before the fix with McpExecutionNotFoundError) and a browser scenario that loads the approval page and approves through the UI.

Recording of the browser scenario: https://github.com/UsefulSoftwareCo/executor/blob/elicitation-resume-repro/e2e/recordings/mcp-browser-resume-page.mp4

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 6e7a442 Commit Preview URL

Branch Preview URL
Jul 04 2026, 09:36 AM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 6e7a442 Jul 04 2026, 09:37 AM

@pkg-pr-new

pkg-pr-new Bot commented Jul 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1317

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1317

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1317

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1317

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1317

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1317

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1317

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1317

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1317

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1317

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1317

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1317

executor

npm i https://pkg.pr.new/executor@1317

commit: 6e7a442

@RhysSullivan RhysSullivan marked this pull request as ready for review July 4, 2026 09:50
@RhysSullivan RhysSullivan merged commit 8e49072 into main Jul 4, 2026
41 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant