Fix Autumn customer balances missing the expanded feature (release 0.9.1)#8
Merged
Merged
Conversation
autumn-js's useCustomer always requests expand=balances.feature and asserts the expansion; 0.9.0's balances carried only feature_id, so every consuming render threw customerToFeatures into the app's error boundary. Synthesize the feature from the plan item on every balance, matching the real API's expanded shape, with a regression test that drives the real SDK against the emulator. Release 0.9.1.
RhysSullivan
added a commit
to UsefulSoftwareCo/executor
that referenced
this pull request
Jul 2, 2026
…tumn gap emulate 0.9.0's Autumn customer balances omit the expanded feature object autumn-js asserts, so useCustomer crashes the org page into the error boundary. Fixed upstream in UsefulSoftwareCo/emulate#8 (0.9.1); unskip once the publish lands and the e2e dependency is bumped.
RhysSullivan
added a commit
to UsefulSoftwareCo/executor
that referenced
this pull request
Jul 2, 2026
0.10.0 ships the Autumn balances.feature expansion autumn-js asserts (UsefulSoftwareCo/emulate#8), so the org page renders again and the scenario passes.
RhysSullivan
added a commit
to UsefulSoftwareCo/executor
that referenced
this pull request
Jul 2, 2026
* e2e: fix stale docs, harden dev-CLI status, add cloud+selfhost CI jobs - e2e/AGENTS.md: the anatomy example predated the service-yielding scenario() signature (no more needs/ctx); capability notes said browser was cloud-only and mcp-oauth selfhost-only, both wrong per targets/*.ts; file placement now lists cloudflare/, local/, cli/; document summary, motel, test:* scripts, the viewer/ SPA, pr-media, and the Windows desktop/cli VM targets. - e2e dev CLI status: probe the app URL before reporting ready (a zombie runner with a dead server used to read as healthy), and only parse real state files in .dev/ (cloud.journey.json rendered as a garbage DEAD line). - CI: run the cloud and selfhost e2e projects on every PR/push with failure artifacts (trace.zip, session.mp4, step screenshots) uploaded per target. * Fix the MCP regressions and policy gaps the e2e suite caught Cloud (hibernatable MCP DO rework fallout): - server.ts no longer gates MCP dispatch behind the Axiom tracer install: with AXIOM_TOKEN unset (any dev boot without motel) every /mcp request fell through to the SPA router and 404ed. - agent-handler mounts a second serve() on /mcp/toolkits/:slug — the agents SDK builds an exact-match URLPattern, so the single /mcp handler never saw toolkit paths. - Restore the old envelope's transport contract: JSON-RPC 405 for verbs outside GET/POST/DELETE/OPTIONS (was a bare 404), 200 for session DELETE (agents SDK answers 204), and a reconnect-worded 404 for requests that race a condemned DO's abort. Selfhost (org-scoped MCP OAuth discovery): - The org-segment strip middleware now carries the original pathname in an internal header, and the protected-resource metadata echoes it, so a client that dialed /<org>/mcp/... passes the MCP SDK's RFC 9728 resource check. Bare paths are untouched; the header is stripped from unrewritten requests. Microsoft Graph URL policy: - microsoftHttpPlugin gains the hosts' local-network dev posture: selfhost, cloud, and the cloudflare host thread allowLocalNetwork into allowUnsafeUrlOverrides, and the override now also admits plain-http loopback URLs (local emulators). Production behavior is unchanged: the flag is unset there, and non-loopback http stays rejected even with it. Stale e2e assertion refreshed for an intentional product change: - tool-descriptions: the execute inventory is names-only since the skills tool slimming; drop the per-connection description assertions. * test(e2e): repair self-host scenarios and gate the suite in CI The self-host e2e project never ran in CI, so it drifted red while the app moved on. Repair the failing scenarios (stale connect-modal selectors, a racy action-bar position read, a shared-admin connection-count assertion, a multi-tenant-only org-slug 404 step, and a cloud-shaped toolkit MCP URL), add a documented skip affordance to the scenario helper, and quarantine the two Microsoft emulator scenarios that need a canonical block-YAML Graph spec (tracked separately). Cherry-picked from origin/fix-selfhost-e2e-and-ci (PR #1239); its CI job is superseded by the cloud+selfhost matrix job already on this branch. * test(e2e): quarantine the two agents-SDK transport gaps Both are real gaps in the hibernatable Agent bridge (standalone SSE supersede never resolves; response routing scopes JSON-RPC ids per session instead of per stream), not regressions on this branch. Skip with reasons so the suite gates CI while the gaps stay visible; fixing the bridge is tracked separately. * test(e2e): repair or quarantine the cloud scenarios that drifted on main The cloud e2e project never gated CI either, so ten scenarios rotted. Refresh the four whose product behavior moved intentionally: - connect-card-ssr-origin: install URLs are org-slug-scoped since the org-slug console URLs change (#974); accept the slug form. - connection-owner-isolation: /api/auth/switch-organization was deleted with cookie-based org switching (#1000); switch orgs the way the web client does, via the x-executor-organization selector header. - oauth-connections: the popup-state fix (#1235) envelopes the callback state as base64url JSON; decode it and assert the inner state + orgSlug. - unauthenticated-skeleton: the 404 page shipped as a standalone page in the same commit as the shell-framed assertion (#986); assert the page it actually renders. Quarantine the six that need product/harness work, each with a reason: mcp-browser-approval-org-scope + the two browser-approval scenarios (cloud-only: the mcporter browser-approval completion never lands), cli-device-login (device-flow terminal never reaches the emulator), and run-panel-auto-approve (autoApprove leaves the run paused; never green since the feature landed in #1183). * lint: suppress the adapter-boundary error checks in the MCP agent handler The condemned-DO abort surfaces as a plain runtime Error thrown out of the agents SDK's serve.fetch; its message string is the only signal. Narrow suppressions with boundary reasons, per the typed-errors skill. * test(e2e): quarantine the seat-limit scenario on the emulate 0.9.0 Autumn gap emulate 0.9.0's Autumn customer balances omit the expanded feature object autumn-js asserts, so useCustomer crashes the org page into the error boundary. Fixed upstream in UsefulSoftwareCo/emulate#8 (0.9.1); unskip once the publish lands and the e2e dependency is bumped. * ci: retrigger * ci: shard the cloud e2e job so each shard gets a fresh dev stack A full-suite run against one long-lived cloud dev server degrades partway through: sign-in starts refusing connections and everything after fails with fetch errors (the same SSE/OTel memory growth being instrumented on main). Four shards, each booting its own stack, stay under the threshold. Re-merge into one job once the leak is fixed. * ci: split the cloud e2e job into eight shards Four shards still hit the dev-server degradation a few minutes in on 2-core runners; eight keeps each stack's lifetime under the threshold. * ci: retry flaky browser scenarios twice on the same stack The remaining shard failures are scattered single-test Playwright waitFor timeouts on 2-core runners, not systemic stack death; vitest --retry clears them without hiding real regressions (a consistent failure still fails after 3 attempts). * test(e2e): quarantine the Graph default-add scenario on CI runners Compiling the Graph spec inside dev workerd 500s on 2-core GitHub runners and takes the dev stack down for every scenario after it in the shard (the auth-hint/org-slug/docs-link failures in the same shard were all downstream of this). Local runs are unaffected; skip only under CI. * selfhost: read the local-network posture from env in the plugins seam plugins() runs per request; loadConfig() does filesystem work (data dir, secret key resolution) that should not ride the request path. The env read is the same computation loadConfig makes for the flag. * e2e: bump @executor-js/emulate to 0.10.0, unskip the seat-limit scenario 0.10.0 ships the Autumn balances.feature expansion autumn-js asserts (UsefulSoftwareCo/emulate#8), so the org page renders again and the scenario passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.9.0 Autumn emulator's per-feature
balancesoncustomers.get_or_createomitted the nestedfeatureobject. autumn-js'suseCustomeralways requestsexpand: ["balances.feature"]and asserts the expansion, so every consuming UI render threw[customerToFeatures] please expand balances.featureinto the app's error boundary (caught by executor's cloud e2e billing scenario).Every balance entry now embeds a feature synthesized from its plan item, matching the real API's expanded shape. Regression test drives the real autumn-js SDK against the emulator and replicates the SDK's own guard.
Bumps to 0.9.1 with the changelog entry so CI publishes on merge.