Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Bump node, vscode-jsonrpc and typescript versions - #18

Merged
akosyakov merged 2 commits into
masterfrom
bumpVersions
Feb 3, 2020
Merged

Bump node, vscode-jsonrpc and typescript versions#18
akosyakov merged 2 commits into
masterfrom
bumpVersions

Conversation

@RomanNikitenko

Copy link
Copy Markdown
Contributor

Closes #17

We need it to bump the new Monaco version, please see more details here

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@akosyakov

Copy link
Copy Markdown
Contributor

@RomanNikitenko do you need any assistance?

@RomanNikitenko

RomanNikitenko commented Jan 30, 2020

Copy link
Copy Markdown
Contributor Author

@akosyakov
I was switched on blocker issue in our repo, but today I'm coming back to the issues related to upgrade to the latest Monaco.

About the current PR changes - I tested these changes in two ways:

  • by adding vscode-ws-jsonrpc to workspaces in package.json file for monaco-languageclient, build and start the node-example. It works well for me. Also I can see that node_modules of
    monaco-languageclient contains 5.0.0 version of vscode-jsonrpc

  • using yarn link for vscode-ws-jsonrpc with my changes and yarn link "vscode-ws-jsonrpc" for monaco-languageclient
    For this case I have the problems.
    It brings me correct vscode-ws-jsonrpc package, but incorrect version of vscode-jsonrpc.
    https://youtu.be/9YfVR0m2quk

I see that the ci job is failed, also I would like to test these changes for theia repo before opening the PR for review.
So today I'm working on these problems.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko

Copy link
Copy Markdown
Contributor Author

@akosyakov
The errors was fixed by changing version of @types/node to 10.17.14

Tested these changes for theia repo and monaco-languageclient repo by adding to the corresponding package.json file as dependency my local package: "vscode-ws-jsonrpc": "file:../../vscode-ws-jsonrpc".

I don't see any compilation errors and both node-example and theia look working for me!

So I'm opening the PR for review. If you have some points what I should test before merging the PR - I'd be happy to do that to be sure that the changes don't broke something.

@RomanNikitenko
RomanNikitenko marked this pull request as ready for review January 31, 2020 15:31
@RomanNikitenko RomanNikitenko changed the title Bump vscode-jsonrpc and typescript versions Bump node, vscode-jsonrpc and typescript versions Jan 31, 2020
@akosyakov
akosyakov merged commit a69bee3 into master Feb 3, 2020
@akosyakov
akosyakov deleted the bumpVersions branch February 3, 2020 10:20
@akosyakov

Copy link
Copy Markdown
Contributor

Published 0.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to vscode-jsonrpc 5.0.0

2 participants