Conversation
CGNonofr
left a comment
There was a problem hiding this comment.
LGTM, lots of unrelated changes (logs) included though :)
|
@CGNonofr yes, forgot to mention. The debug logging is improved (better timestamp and better and more precise messages). |
…d enforceLanguageClientDispose to dispose the language client on demand
|
A new next release is available (only the component this time): |
|
@martin-fleck-at is this a possible solution for you? |
|
@kaisalmen I am a bit swamped today. I might have a chance to try this out but I might only be able to have a more detailed look tomorrow. Sorry for the delay! |
|
@martin-fleck-at now worries. Take your time. I will wait for you feedback. |
martin-fleck-at
left a comment
There was a problem hiding this comment.
I can confirm that issue #996 is resolved for me with that one. I could not longer reproduce the fast typing issue. Great work, thank you very much @kaisalmen!
I did add some minor comments but nothing that should prevent this PR from being merged.
|
@martin-fleck-at thanks for the useful comments. I will incorporate your feedback tomorrow. |
…hat needs to be increased to trigger. Fixed enforceLanguageClientDispose
|
@CGNonofr and @martin-fleck-at I have implemented the review comments. Additionally, I changed New next releases are available: |
Use flags
reprocessConfigto trigger a editor config re-processing. This can trigger an on-demand re-processing of the text/model and editor options (test with statemachine react example)Use
enforceLanguageClientDisposeto dispose the language client on demand: This was moved from the config to the react component as it is only used here.Debug logging was improved.
This resolves #996