Skip to content

Always create a getWorker function - #918

Merged
kaisalmen merged 1 commit into
mainfrom
issue-913
May 5, 2025
Merged

Always create a getWorker function#918
kaisalmen merged 1 commit into
mainfrom
issue-913

Conversation

@kaisalmen

Copy link
Copy Markdown
Collaborator

This fixes #913

A getWorker function is always created. If none is provided with the WrapperConfig an empty one is created. The empty one will throws errors for all requested workers.

@kaisalmen
kaisalmen requested a review from CGNonofr as a code owner May 5, 2025 13:18
@kaisalmen

Copy link
Copy Markdown
Collaborator Author

FYI @montymxb

@CGNonofr CGNonofr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisalmen
kaisalmen merged commit e7070c6 into main May 5, 2025
@kaisalmen
kaisalmen deleted the issue-913 branch May 5, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Monaco-Editor-React Fails Without Default monacoWorkerFactory

2 participants