Handle languageclient errors cases more robustly - #859
Merged
Conversation
kaisalmen
force-pushed
the
discussion-855
branch
from
February 14, 2025 12:43
3acab64 to
56f4992
Compare
Collaborator
Author
- Added a unit test
Collaborator
Author
|
@CGNonofr last commit is for the problem @cdietrich discovered with the react component introduced by 6.3.0 version. We now have 78 unit tests. |
CGNonofr
approved these changes
Feb 14, 2025
CGNonofr
left a comment
Collaborator
There was a problem hiding this comment.
not easy to review! 😢 LGTM though
Collaborator
Author
|
@CGNonofr sorry, once I started fixing the tests the domino effect started. |
Collaborator
As always, same for me 😆 |
Collaborator
Author
|
@CGNonofr These changes made the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved some tests around (wrong places) as well.
Fixing the wrapper handling in case of error introduced required changes to the react component and to several tests.
After thinking about #855