Convert all values of MarkerSeverity in the converter - #71
Conversation
Fixed the switch statement so that it would convert MarkerSeverity.Hint to DiagnosticSeverity.Hint. Signed-off-by: Remy Suen <remy.suen@gmail.com>
|
@rcjsuen, I'm not sure about the change logs and the next release. I think, I'll add a change and do a 0.6.0 release if there are not objections. As @akosyakov mentioned currently published |
|
Thanks for the review, @AlexTugarev. I've merged the changes into If you want to just version the next release Here's a diff of what I think needs to be done.
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 000e43b..d27523c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,8 +1,8 @@
# Changelog
All notable changes to this project will be documented in this file.
-## [Unreleased]
-- updated dependency to Monaco 0.11 ([#61](https://github.com/TypeFox/monaco-languageclient/issues/61))
+## [0.6.0] - 2018-04-18
+- updated dependency to Monaco 0.12 ([#70](https://github.com/TypeFox/monaco-languageclient/pull/70))
- support `CompletionItem`'s `additionalTextEdits` property ([#39](https://github.com/TypeFox/monaco-languageclient/issues/39))
- convert `monaco.MarkerSeverity.Hint` values to `DiagnosticSeverity.Hint` ([#71](https://github.com/TypeFox/monaco-languageclient/pull/71))
@@ -29,7 +29,7 @@ All notable changes to this project will be documented in this file.
## 0.1.0 - 2017-0
- initial 0.1.0 release, depends on Monaco 0.9.0
-[Unreleased]: https://github.com/TypeFox/monaco-languageclient/compare/v0.4.0...HEAD
+[0.6.0]: https://github.com/TypeFox/monaco-languageclient/compare/v0.4.0...v0.6.0
[0.4.0]: https://github.com/TypeFox/monaco-languageclient/compare/v0.3.0...v0.4.0
[0.3.0]: https://github.com/TypeFox/monaco-languageclient/compare/v0.2.1...v0.3.0
[0.2.1]: https://github.com/TypeFox/monaco-languageclient/compare/v0.2.0...v0.2.1 |
|
That's very kind of you, @rcjsuen! Thanks! Will do so. |
It seems that
monaco.MarkerSeverity.Hintis not being considered when converting a Monaco marker to an LSP Diagnostic so I fixed the converter.monaco-languageclient/src/converter.ts
Lines 181 to 191 in 3c7a4eb