Adapt to monaco-vscode-api-1.79.1

[kaisalmen]

@CGNonofr I have a problem even if I only include files and model. Any idea on this?

I changed initServices that users can only include editor or views as you outlined in the monaco-vscode-api README

[kaisalmen]

Is it possible I import things from monaco-editor suddently twice?

[CGNonofr]

monaco-vscode-api includes the reference search from vscode
so monaco-editor/esm/vs/editor/standalone/browser/referenceSearch/standaloneReferenceSearch shouldn't be included, nor directly monaco-editor obviously

[kaisalmen]

This means importing:

import 'monaco-editor/esm/vs/editor/edcore.main.js'

is now forbidden

[CGNonofr]

It seems so!

btw, it was already a bad idea, as most of them are not functionnal, like toggleHighContrast and inspectTokens.

At least now we can't make the mistake or importing it (:

[kaisalmen]

I have forced pushed another update and checked that all examples are working fine again.
One important finding: If you use quickaccess then keybindings must be loaded otherwise triggering the command palette does not work. An error is written to the console. I handle this in the init here, but maybe something you should already handle on monaco-vscode-api level.

[kaisalmen]

This is ready. I just released: https://www.npmjs.com/package/monaco-languageclient/v/6.1.0-next.1

[kaisalmen]

@CGNonofr do want to change something in monaco-vscode-api regarding quickaccess and keybindings and we should wait for it or is this PR ok as is?

[CGNonofr]

I don't know it it's a good idea to implicitly includes other services (keybindings from quickaccess)

[kaisalmen]

I don't know it it's a good idea to implicitly includes other services (keybindings from quickaccess)

At least better than not working. Do you prefer throwing errors suggesting what to do?

[CGNonofr]

I don't know it it's a good idea to implicitly includes other services (keybindings from quickaccess)

At least better than not working. Do you prefer throwing errors suggesting what to do?

I think it's preferable

[kaisalmen]

I am 50/50 on that, but with more services (I have seen the next branch with more services 😱 😆 ) and growing complexity it might be a better idea.

[kaisalmen]

@CGNonofr now errors are thrown, if dependent services are not configured. I kept the files service being always loaded. Any further objections?

[CGNonofr]

now errors are thrown

you mean no?

[kaisalmen]

Sorry I corrected the sentence above: "now errors are thrown, if dependent services are not configured"