Skip to content

Update to monaco 0.34/vscode 1.69 - #409

Merged
CGNonofr merged 5 commits into
mainfrom
update-monaco-0.34
Aug 16, 2022
Merged

Update to monaco 0.34/vscode 1.69#409
CGNonofr merged 5 commits into
mainfrom
update-monaco-0.34

Conversation

@CGNonofr

Copy link
Copy Markdown
Collaborator

No description provided.

@CGNonofr
CGNonofr requested a review from kaisalmen as a code owner August 14, 2022 01:24

@kaisalmen kaisalmen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just released 0.34.0 of monaco-editor-workers and therefore pushed an update.

@kaisalmen

Copy link
Copy Markdown
Collaborator

Pushed the lock file.

@CGNonofr

CGNonofr commented Aug 15, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks! note that monaco-vscode-api@1.69 is ONLY compatible with monaco 0.34 therefore I think any monaco-languageclient update of monacy-editor should be a major release

@kaisalmen

Copy link
Copy Markdown
Collaborator

Yes, I was thinking the same thing. 3.0.0 shall it be! I will prepare the release.

Thank you for your work! I saw the service additions in monaco-vsocde-api.

@kaisalmen

Copy link
Copy Markdown
Collaborator

I have pushed another update with some changes to the README and CHANGELOG.
I tested it locally and it looks good.
If you think, we are good to go, please presse the merge button, then I will produce the release.

@CGNonofr
CGNonofr merged commit 1fc5663 into main Aug 16, 2022
@CGNonofr
CGNonofr deleted the update-monaco-0.34 branch August 16, 2022 10:26
@CGNonofr

CGNonofr commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator Author

FYI, monaco-vscode-api was designed at first to only provide the programmatic VSCode api, but it evolved and now provides a way to use the declarative VSCode API (the things declared in the package.json of extensions)

I created a demo: CodinGame/monaco-vscode-api#39

@kaisalmen

kaisalmen commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

Forgot to write: Made the release yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants