Merge monaco-jsonrpc and vscode-ws-jsonrpc into new sub package - #383
Merged
Conversation
kaisalmen
requested review from
BroKun,
RomanNikitenko,
asual,
azatsarynnyy,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
June 17, 2022 17:12
kaisalmen
changed the title
Collaborator
Author
|
dev version is now available: |
kaisalmen
force-pushed
the
monaco-jsonrpc
branch
2 times, most recently
from
June 20, 2022 15:33
44d7319 to
1638fe1
Compare
CGNonofr
approved these changes
Jun 21, 2022
CGNonofr
left a comment
CGNonofr
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍
Btw, What about releasing a 1.0.0?
- Aligened code with node 16 api - Moved CHANGELOGs to packages and the top-level one links to them - Aligned tsconfigs
kaisalmen
force-pushed
the
monaco-jsonrpc
branch
from
June 21, 2022 09:36
1638fe1 to
1354a94
Compare
Collaborator
Author
Yes, that makes sense. I wanted to compare the real npm package contents before doing a next release. I need to verify I did change the content accidentally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #367.
Releases will continue as
vscode-ws-jsonrpc. I am currently unable to do a dev release. That will change latest on Monday. 🙂