Clean unregistered featured from registration requests - #372
Merged
Conversation
CGNonofr
requested review from
BroKun,
RomanNikitenko,
asual,
azatsarynnyy,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
June 3, 2022 18:29
Collaborator
Author
|
The only other way is to create a PR on the vscode-languageserver-node itself, I'll try to have a look 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reasons, if the server sends a capability registration batch to the client and one feature is not registered on the client, all registration after it in the list won't be registered (see https://github.com/microsoft/vscode-languageserver-node/blob/a6f0d22d2c6842337ad135c13d2f945e53b1a6e4/client/src/common/client.ts#L1741)
Do you have a better idea?