Introduce global engines entries for node and npm - #370
Merged
Conversation
kaisalmen
requested review from
BroKun,
RomanNikitenko,
asual,
azatsarynnyy,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
May 30, 2022 08:57
Collaborator
|
Good idea 👍 btw, what about adding the volta config as well? |
Collaborator
Author
I didn't know that one. I had to look it up. It makes sense. Do you use it and do you recommend it? I am working with Windows/Linux (WSL2) hybrid machines, so I am always interested in things that work in both worlds. |
Collaborator
Yes we do use volta everywhere at CodinGame for some months |
kaisalmen
commented
May 31, 2022
| "node": ">=16.0.0", | ||
| "npm": ">=7.10.0" | ||
| }, | ||
| "volta": { |
Collaborator
Author
There was a problem hiding this comment.
I pinned the latest version of node and npm. Is that ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't we generally stick to node LTS? npm
7.10.0is the npm version bundled with node16.0.0that's why I choose that version number.