Remove unsupported features - #364
Merged
Merged
Conversation
CGNonofr
requested review from
BroKun,
RomanNikitenko,
asual,
azatsarynnyy,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
May 27, 2022 09:01
kaisalmen
reviewed
May 30, 2022
kaisalmen
left a comment
kaisalmen
left a comment
Collaborator
There was a problem hiding this comment.
I don't understand how the "optional" feature should work.
| this.registerFeature(new DiagnosticFeature(this)); | ||
| } | ||
|
|
||
| public registerTextDocumentSaveFeatures() { |
Collaborator
There was a problem hiding this comment.
Who is responsible for calling three methods (registerTextDocumentSaveFeatures, registerConfigurationFeatures, registerProgressFeatures)?
Collaborator
Author
There was a problem hiding this comment.
The user who is using the MonacoLanguageClient, aka,
const languageClient = new MonacoLanguageClient(...)
languageClient.registerTextDocumentSaveFeatures()Since these feature are builtin in vscode but NOT builtin in monaco (they require some additional code), I don't thing they belong in the registerBuiltinFeatures method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some features are not supported at all:
Some require some code and are not
builtin: