Fix dropped tags in Diagnostic -> IMarkerData - #297
Merged
Conversation
rw-access
requested review from
BroKun,
RomanNikitenko,
asual,
azatsarynnyy,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
October 29, 2021 21:54
Collaborator
|
Thank you 👍 Can you just squash your 2 commits please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting diagnostics from the language client DIagnostic from into IMarkerData, the
tagfield was dropped.This keeps that field present in the diagnostic.
Here's confirmation of this locally with the
Unnecessarytag on allfalsevalues, and no diagnostics ontrue: