Async resolve code actions - #294
Merged
Merged
Conversation
CGNonofr
requested review from
BroKun,
RomanNikitenko,
asual,
azatsarynnyy,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
October 11, 2021 08:49
CodeAction.is would return false if there is no edit field
CGNonofr
force-pushed
the
async-resolve-code-actions
branch
from
October 11, 2021 08:54
e329787 to
f85fe90
Compare
mofux
approved these changes
Oct 11, 2021
mofux
left a comment
mofux
left a comment
Contributor
There was a problem hiding this comment.
I have not tested but the PR looks good 👌
Collaborator
Author
|
I'm currently testing it, I'll merge it as soon as I'm convinced it works fine! btw it's still published under @codingame/monaco-languageclient@0.16.0 |
Collaborator
Author
|
It seems to work pretty well, I'm merging it, thanks a lot @mofux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monaco editor has been updated, we're now able to properly implement code action resolving