Ensure that SignatureHelp and SignatureHelp has non-null arrays - #112
Merged
Conversation
While the LSP allows a SignatureHelp's signatures array to be optional, Monaco does not so we should ensure that it is initialized with a zero length array if the value from the language server is null or undefined. Signed-off-by: Remy Suen <remy.suen@gmail.com>
While the LSP allows a SignatureInformation's parameters array to be optional, Monaco does not so we should ensure that it is initialized with a zero length array if the value from the language server is null or undefined. Signed-off-by: Remy Suen <remy.suen@gmail.com>
Contributor
Author
|
The Either way, we should fix both of these cases... |
rcjsuen
changed the title
akosyakov
approved these changes
Sep 3, 2018
|
Is this PR supposed to fix Monaco Editor #1045? I have tried to upgrade to 0.8.0, but the crash issue still persists. |
Contributor
Author
|
Hi, @hifall. It should but it sounds like I missed something. Please open a bug and describe your setup and versions there. |
|
Filed as Issue #115. |
Closed
|
Confirmed working. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the LSP allows a
SignatureHelp's signatures array to be optional, Monaco does not so we should ensure that it Monaco's representation of aSignatureHelpis properly initialized with a zero length array if the value from the language server isnullorundefined.See microsoft/monaco-editor#1045.