-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Allow scoping Operator installation on specific namespaces #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
f375654
6468db4
30b1b80
ad183e1
66897c3
3821996
131d190
4749f24
e613a08
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,22 @@ twingateOperator: {} | |
| # tag1: value_for_tag1 | ||
| # tag2: value_for_tag2 | ||
|
|
||
| ## Restrict operator to monitor resources in specific namespaces. You should either: | ||
| ## 1. Specify a list of namespaces: | ||
| ## namespaces: ["foo-dev", "foo-stg"] | ||
| ## 2. Use globs to match multiple namespaces: | ||
| ## namespaces: ["*-dev", "*-stg"] | ||
| ## 3. Use negation to include all namespaces except those excluded: | ||
| ## namespaces: ["!*-test"] | ||
| ## 4. Use multiple globs in one pattern: | ||
| ## namespaces: ["foo-*,!*-test"] | ||
| ## For more information on using multiple globs, see: https://kopf.readthedocs.io/en/stable/scopes | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is the full explanation of how the comma-separated globs pattern works. I didn't include it here because it's very long and overwhelming. Maybe we could even remove this example so it's simpler, even though we support it. I think in most cases, method 1-3 should be sufficient? 🤔
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I second this. I read the kopf example and it was quite unexpected how this comma-separated syntax works... @ekampf WDYT?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whats this comment format with ##? Make it look like the rest of the file please
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also we dont need to point to kopf
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ekampf removed the
Not sure if I understand, do you mean removing the URL to kopf in line 34? |
||
|
|
||
| ## Note: Defining glob patterns as a separate array elements is different from defining comma-separated patterns within a single element. | ||
| ## For example, `namespaces: ["foo-*", "!*-test"]` is not the same as `namespaces: ["foo-*,!*-test"]` | ||
| ## `namespaces: ["foo-*", "!*-test"]` will evaluate each glob pattern independently and combine the results. | ||
| # namespaces: ["default"] | ||
|
|
||
| # Twingate Kubernetes Access is currently in beta. Sign up for early access at https://www.twingate.com/product/kubernetes-access. | ||
| kubernetes-access-gateway: | ||
| enabled: false | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation?