feat(api+engine): add per-workspace all-actions override for error details - #3599
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
✅ No security or compliance issues detected. Reviewed everything up to 1d11d77. Security OverviewDetected Code Changes
|
Contributor
Author
Contributor
Author
|
Follow-up browser QA with real Anthropic Claude Haiku executions, covering the agent → MCP registry-tool cascade. Agent error-details cascadeWorkspace allow-listed for per-action opt-in, not break glass. Both runs made one
Environment and scopeLocal agent execution needed |
…ting Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
uv run pytest tests/unit/test_executor_service.py tests/unit/test_organization_settings.py tests/unit/api/test_api_workspaces.py tests/unit/test_agent_tokens.py tests/unit/test_durable_agent_workflow_search_attributes.py)Description
Extends #3497 (org-gated per-action "Show error details") with two things:
1. Org-level all-actions list per workspace. New org setting
app_unsafe_disable_secret_error_withholding_all_actions_workspace_ids. Any workspace inthat list has secret error withholding disabled for every action, no per-action opt-in
required. The two lists resolve to a single policy (
tracecat/settings/types.py):workspace_allows_error_details()is replaced byworkspace_error_details_policy().The executor now resolves the policy on every
invoke_once(TTL-cached 15s perorg+workspace, as before) instead of only when the action opted in, so all-actions list
applies to actions that never touched the toggle. Known secret values are still masked
in all modes; this only controls withholding of the diagnostic message.
WorkspaceReadgainsunsafe_disable_secret_error_withholding_forcedalongside theexisting
_allowed. The action panel shows the switch as on + disabled with an"Always enabled ... (all-actions list)" label when forced. Org app settings get a second
workspace checklist for the all-actions list (the checklist is factored into
WorkspaceListField).2. Agent action opt-in cascades to tool calls. Setting "Show error details" on an
agent action now flows to every registry tool the agent invokes:
The flag is still subject to the org workspace policy at execution time; it does not
bypass gating on its own.
Related Issues
Follow-up to #3497.
Steps to QA
details always shown". Open any action in that workspace: the "Show error details"
switch is on and disabled with the all-actions label. Run an action that fails with a
secret in scope: original message shown, secret value masked.
switch is enabled; behaviour follows the per-action toggle.
scope (workspace in the allow-list): the tool error surfaced to the agent shows the
original message rather than "Details withheld".
LOC breakdown
Link to Devin session: https://app.devin.ai/sessions/9a7f6736d6e447dd8187729120e3c4ba
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a7f6736d6e447dd8187729120e3c4ba?variant=devin