feat(pac-proxy-agent): sanitize credentials in PAC proxy result logging - #421
Merged
Conversation
…credentials from log output Add a utility function that sanitizes PAC proxy result strings by replacing embedded credentials (userinfo) with '<credentials>' for safe logging. This prevents credentials from leaking into debug output and error messages when PAC results contain embedded auth like 'PROXY user:pass@host:8080'. The function is also exported for consumers to use directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
sanitizeProxyResultCredentials()utility function that strips embedded credentials (userinfo) from PAC proxy result strings before they are logged viadebug()or included in error messages.Problem
PAC results can contain embedded authentication like
PROXY user:pass@host:8080. When these are logged in debug output or error messages, credentials are exposed.Solution
sanitizeProxyResultCredentials()that replaces userinfo with<credentials>(e.g.PROXY user:pass@host:8080→PROXY <credentials>@host:8080)debug()calls and the error message inconnect()that include PAC resultsThis matches the approach used in VS Code's
vscode-proxy-agent.