Add casts to avoid warnings when using unity in CPP#836
Open
lucasssvaz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TEST_ASSERT_EACH_EQUAL_FLOATandTEST_ASSERT_EACH_EQUAL_DOUBLEfail to compile in C++ becauseUnityFloatToPtr()/UnityDoubleToPtr()returnUNITY_INTERNAL_PTR(const void*), whileUnityAssertWithinFloatArray()/UnityAssertWithinDoubleArray()expectconst UNITY_FLOAT*/const UNITY_DOUBLE*.C allows that conversion implicitly; C++ does not.
Fix
Cast the helper return value in the internal macros:
Integer TEST_ASSERT_EACH_EQUAL_* macros are unaffected because they call UnityAssertEqualIntArray(), which already takes UNITY_INTERNAL_PTR.
Tested locally. Solves the issue.