reverted EmptySearchResult, copied newest develop branch, formatted S… - #951
Conversation
…earchResultsScreen.tsx and added LoadingIndicator
|
@lifeeeDEV is attempting to deploy a commit to the Streamability Team on Vercel. A member of the Team first needs to authorize it. |
lifeeeDEV
changed the title
There was a problem hiding this comment.
It was by accident, I am sorry.
| it('a clickable "Load More" button is displayed when `moreToFetch` is true', async () => { | ||
| vi.mocked(usePaginatedData).mockReturnValue({ | ||
| data: TRENDING_DATA, | ||
| setData: () => {}, | ||
| loading: false, | ||
| moreToFetch: true, | ||
| refetch: () => {}, | ||
| }); | ||
|
|
||
| render(<RouterProvider router={router} />); | ||
|
|
||
| await screen.findByTestId('search-results-screen'); | ||
| expect(screen.getByText('Load More')).toBeInTheDocument(); | ||
| expect(screen.getByText('Load More')).not.toHaveAttribute('disabled'); |
There was a problem hiding this comment.
Ideally we could test for the loading spinner, but I think I am fine to break that out into a new issue as it might be difficult.
There was a problem hiding this comment.
I removed the tests for the Load More Button since it was replaced with the LoafingIndicator
Thenlie
left a comment
Thenlie
left a comment
There was a problem hiding this comment.
The loading indicator itself looks good! Just a couple questions about the deleted file and test.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1,7 +1,7 @@ | |||
| # Create .env file and add these environment variables. | |||
| # Use `npm run db-spart-env` to auto-generate the supabase keys. | |||
Thenlie
left a comment
Thenlie
left a comment
There was a problem hiding this comment.
Awesome! Thanks for the contribution and welcome to the Stream Team! 🥳
2 participants
Description
Reverted other documents such as EmptySearchResult. Formatted LoadingIndicator into LF. no lint problems checked with
npm run lint. Removed src/tests/screens/SearchResultsScreen.test.tsx -> Test forLoad More ButtonChecklist
developnotmain)feature,documentation, etc.)Closes #<issue-number>added if this resolves a GitHub issuegit rebase developif necessarynpm run todo-ciran if any todo comments were created