refactor: cleanup GenerateSubsets - #6373
Merged
DenizAltunkapan merged 2 commits intoJul 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6373 +/- ##
=========================================
Coverage 74.64% 74.64%
+ Complexity 5444 5443 -1
=========================================
Files 682 682
Lines 18999 18998 -1
Branches 3668 3668
=========================================
Hits 14181 14181
+ Misses 4261 4259 -2
- Partials 557 558 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GenerateSubsets
DenizAltunkapan
approved these changes
Jul 13, 2025
DenizAltunkapan
left a comment
Member
There was a problem hiding this comment.
Your cleanups are very helpful, especially the lack of javadoc above the class suprises me
DenizAltunkapan
enabled auto-merge (squash)
July 13, 2025 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java