chore: bump aweXpect to v2.36.0 - #1019
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with the PR intent, and the build scope/version updates are applied in the expected centralized locations.
Pull request overview
Updates the repository’s centrally-managed aweXpect package version to the v2.36.0 release and restores the Fallout build pipeline scope to its normal default behavior.
Changes:
- Switch build pipeline scope from
MainOnlyback toDefaultin the Fallout build definition. - Bump the centrally-managed
aweXpectpackage version from2.36.0-DEV.2to2.36.0.
File summaries
| File | Description |
|---|---|
| Pipeline/Build.cs | Restores the build pipeline’s BuildScope to Default. |
| Directory.Packages.props | Updates the centralized aweXpect package version to 2.36.0. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🚀 Benchmark ResultsDetails
|
Also restore build scope to "Default" and move the Xunit3.Core.Tests to MTP
df9ed3a to
126570b
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The updated xUnit v3 framework test execution path can attempt to run net48 TFMs via dotnet run on non-Windows agents, which will fail.
Review details
Suppressed comments (1)
Pipeline/Build.FrameworkTest.cs:120
XunitTestingPlatformFrameworksbuildstestCombinationsfrom all target frameworks without filtering outnet48, unlikeVsTestFrameworks. Since these xUnit v3 projects inheritTargetFrameworksincludingnet48,DotNetRunwill try to execute thenet48TFM on non-Windows agents and will fail (no .NET Framework runtime).
Solution.Tests.Frameworks.aweXpect_Frameworks_Xunit3_Core_Tests,
Solution.Tests.Frameworks.aweXpect_Frameworks_Xunit3_Tests,
];
var testCombinations =
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
|
This is addressed in release v2.37.0. |



Also restore build scope to "Default" and move the Xunit3.Core.Tests to MTP