chore: bump aweXpect.Core to v2.33.0 - #1018
Conversation
20b1061 to
d3895dc
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with the existing build/publishing workflow, and limited to a version bump plus restoring the default build scope.
Pull request overview
Updates the repository’s centrally-managed package version for aweXpect.Core and resets the Fallout build pipeline scope back to the normal/default mode after a temporary “core-only” phase.
Changes:
- Bump
aweXpect.Corepackage version from2.32.0to2.33.0in central package management. - Reset
BuildScopefromCoreOnlytoDefaultin the pipeline build configuration.
File summaries
| File | Description |
|---|---|
| Pipeline/Build.cs | Resets build pipeline scope to the default/full build mode. |
| Directory.Packages.props | Updates centrally-managed aweXpect.Core package version to 2.33.0. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
d3895dc to
87ba772
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The configured BuildScope in code conflicts with the PR description and the nearby documentation is misleading about the scope’s actual effects.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
🚀 Benchmark ResultsDetails
|
87ba772 to
566f97a
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The PR description and build configuration/CI changes are inconsistent and the workflow modifications effectively remove/unguard key validation steps (tests/analysis) while also risking artifact timing issues.
Review details
Suppressed comments (1)
Pipeline/Build.cs:23
- PR description says BuildScope is changed from CoreOnly to Default to broaden the build, but the code sets it to MainOnly. With MainOnly, several targets are gated off (e.g., benchmarks/mutation tests/code analysis run only for BuildScope.Default), so the workflow may unintentionally skip them.
/// <summary>
/// Set this flag temporarily when you introduce breaking changes in the core library.
/// This will change the build pipeline to only build and publish the aweXpect.Core or aweXpect package.
/// <para />
/// Afterward, you can update the package reference in `Directory.Packages.props` and reset this flag.
/// </summary>
readonly BuildScope BuildScope = BuildScope.MainOnly;
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The implemented BuildScope value contradicts the PR description’s stated intent to broaden the build scope (Default vs MainOnly).
Review details
Suppressed comments (1)
Pipeline/Build.cs:23
- The PR description says the build scope is being expanded from CoreOnly to Default, but the code sets it to MainOnly. MainOnly appears to run a reduced build/test/publish set (e.g., UnitTestProjects excludes core tests for MainOnly), which contradicts the stated intent to broaden the build scope. Either update the value to Default or adjust the PR description/commit message to match the intended behavior.
/// Afterward, you can update the package reference in `Directory.Packages.props` and reset this flag.
/// </summary>
readonly BuildScope BuildScope = BuildScope.MainOnly;
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
Current BuildScope.MainOnly + empty MainOnly unit-test project list will skip tests and can fail Windows unit test execution, and the scope change also contradicts the PR description.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Pipeline/Build.cs:23
- The PR description says
BuildScopeshould be changed toDefault, but the code sets it toMainOnly. With the currentMainOnlyconfiguration, parts of the pipeline are skipped and (combined with theUnitTestProjectsmapping) can break Windows unit test execution. Please align the value with the intended expanded build scope.
readonly BuildScope BuildScope = BuildScope.MainOnly;
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
42973f7 to
f9e90b7
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The implemented BuildScope and dependency changes don’t match the PR title/description and can materially alter CI behavior (scope gating and package restore).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Pipeline/Build.cs:23
BuildScopeis now set toMainOnly, but the PR description says the build scope should be expanded (CoreOnly → Default). WithMainOnly, the pipeline skips core tests and framework/benchmark targets that are gated behindBuildScope.Default, so this doesn't actually broaden the build as described.
/// This will change the build pipeline to only build and publish the aweXpect.Core or aweXpect package.
/// <para />
/// Afterward, you can update the package reference in `Directory.Packages.props` and reset this flag.
/// </summary>
readonly BuildScope BuildScope = BuildScope.MainOnly;
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
f9e90b7 to
916bb24
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The build-scope change in Pipeline/Build.cs does not match the PR description’s intent to broaden the build scope (Default vs MainOnly) and materially affects which tests/targets run.
Review details
Suppressed comments (1)
Pipeline/Build.cs:23
- BuildScope is set to MainOnly, but the PR description says the build scope was changed to Default to broaden the build. With MainOnly, several targets/tests that are gated on BuildScope.Default (e.g., framework tests/benchmarks/mutation tests) will remain disabled and core-specific tests/API checks are also skipped, so the build scope is not actually broadened as described.
/// This will change the build pipeline to only build and publish the aweXpect.Core or aweXpect package.
/// <para />
/// Afterward, you can update the package reference in `Directory.Packages.props` and reset this flag.
/// </summary>
readonly BuildScope BuildScope = BuildScope.MainOnly;
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
|
This is addressed in release v2.36.0. |
This pull request updates package dependencies and build configuration to align with the latest standards and enable a broader build scope. The most important changes are:
Dependency Updates:
aweXpect.Corepackage version from2.32.0to2.33.0inDirectory.Packages.props, ensuring the project uses the latest features and bug fixes from the dependency.aweXpectto a pre-release version2.36.0-DEV.2used for own tests.Build Configuration:
BuildScopeinPipeline/Build.csfromCoreOnlytoMainOnly, which expands the build process to include additional components beyond the core.