HidClass::control_xxx: check interface number - #26
Merged
Conversation
Owner
|
I suppose it is related to rust-embedded-community/usb-device#42 ? You need to rustfmt. I'll try on my keyboard and if is works, OK to merge. |
Contributor
Author
|
Yes it's related, but this PR is standalone. The bug it fixes prevents composite devices with multiple HID interfaces (e.g. keyboard + mouse) and nothing else - a configuration which doesn't need IADs to work on Windows - from working properly too. |
Owner
|
published in v0.1.1. Thanks! Hope you'll enjoy keyberon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
HidClass::control_xxxroutines which prevents it from working in composite devices (request interface number was not checked).Reference: USB HID specification v1.11, sections 7.1.1, 7.2.1 and 7.2.2.