fix(router-core): detect Webpack/Rspack ChunkLoadError in isModuleNotFoundError#7653
Open
sijie-Z wants to merge 1 commit into
Open
fix(router-core): detect Webpack/Rspack ChunkLoadError in isModuleNotFoundError#7653sijie-Z wants to merge 1 commit into
sijie-Z wants to merge 1 commit into
Conversation
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7633.
Problem
isModuleNotFoundError()only detects browser-native ESM import errors. When lazy route chunks are bundled by Webpack or Rspack, a failed dynamic import throwsChunkLoadErrorwith messageLoading chunk 123 failed.... The auto-reload path inlazyRouteComponentis never triggered.Solution
Two additions:
error.name === "ChunkLoadError"error.message.startsWith("Loading chunk")Testing
11 tests added covering Chrome, Firefox, Safari, Webpack, Rspack, and edge cases.