Skip to content

Remove unused feedback feature#165

Merged
LadyBluenotes merged 2 commits into
mainfrom
remove-feedback
Jun 16, 2026
Merged

Remove unused feedback feature#165
LadyBluenotes merged 2 commits into
mainfrom
remove-feedback

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Jun 16, 2026

Copy link
Copy Markdown
Member

Remove the unused feedback feature from @tanstack/intent.

This deletes the feedback implementation, public feedback exports and types, feedback-specific tests, and the bundled feedback-collection meta-skill. It also removes current docs and CLI output that pointed users to feedback collection, while leaving historical changelog entries intact.

Summary by CodeRabbit

  • Removed Features

    • Feedback collection functionality has been removed from the CLI and package API. The feedback command is no longer available.
  • Documentation

    • Updated documentation to remove feedback-related guidance and instructions from quick-start guides and CLI reference materials.
    • Skill documentation updated to reference issue reports instead of feedback-related terminology.

@LadyBluenotes LadyBluenotes requested a review from a team as a code owner June 16, 2026 04:53
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b2104d15-ded3-4a33-b240-06d69443c18c

📥 Commits

Reviewing files that changed from the base of the PR and between 6435257 and afd230a.

📒 Files selected for processing (14)
  • .changeset/pretty-sloths-switch.md
  • docs/getting-started/quick-start-consumers.md
  • packages/intent/README.md
  • packages/intent/meta/domain-discovery/SKILL.md
  • packages/intent/meta/feedback-collection/SKILL.md
  • packages/intent/meta/generate-skill/SKILL.md
  • packages/intent/meta/tree-generator/SKILL.md
  • packages/intent/src/commands/list.ts
  • packages/intent/src/feedback.ts
  • packages/intent/src/index.ts
  • packages/intent/src/types.ts
  • packages/intent/tests/feedback.test.ts
  • packages/intent/tests/meta-feedback.test.ts
  • scripts/validate-skills.ts
💤 Files with no reviewable changes (10)
  • scripts/validate-skills.ts
  • packages/intent/tests/meta-feedback.test.ts
  • docs/getting-started/quick-start-consumers.md
  • packages/intent/tests/feedback.test.ts
  • packages/intent/meta/feedback-collection/SKILL.md
  • packages/intent/src/types.ts
  • packages/intent/src/commands/list.ts
  • packages/intent/src/feedback.ts
  • packages/intent/README.md
  • packages/intent/src/index.ts

📝 Walkthrough

Walkthrough

Removes the feedback-collection feature from @tanstack/intent: deletes feedback.ts (406 lines), strips feedback types from types.ts and re-exports from index.ts, deletes both feedback test files, removes the feedback-collection/SKILL.md meta-skill, updates skill wording from "feedback" to "issue" in three other SKILL.md files, strips the feedback guidance from the list command output, updates the README and quick-start docs, adjusts the validate-skills allowlist, and adds a patch changeset.

Changes

Feedback Feature Removal

Layer / File(s) Summary
feedback.ts module, types, and public API surface removal
packages/intent/src/types.ts, packages/intent/src/index.ts
Removes exported feedback types (FeedbackPayload, MetaFeedbackPayload, AgentName, MetaSkillName, FeedbackFrequency, IntentProjectConfig) from types.ts, deletes the entire feedback.ts module (406 lines of exported functions and SubmitResult interface), and strips all related re-exports from index.ts.
Test removal, list command cleanup, and validate-skills allowlist
packages/intent/src/commands/list.ts, packages/intent/tests/feedback.test.ts, packages/intent/tests/meta-feedback.test.ts, scripts/validate-skills.ts
Removes feedback.test.ts (293 lines) and meta-feedback.test.ts (208 lines), strips the "Feedback:" guidance block from runListCommand output, and replaces 'intent feedback' with npm install @tanstack/ and `npx `@tanstack/intent entries in the ALLOWED_SHELL_COMMANDS whitelist.
Meta-skill deletion, SKILL.md wording updates, and docs/README cleanup
packages/intent/meta/feedback-collection/SKILL.md, packages/intent/meta/generate-skill/SKILL.md, packages/intent/meta/tree-generator/SKILL.md, packages/intent/meta/domain-discovery/SKILL.md, packages/intent/README.md, docs/getting-started/quick-start-consumers.md, .changeset/pretty-sloths-switch.md
Deletes the 234-line feedback-collection/SKILL.md, updates three other SKILL.md files to replace "feedback" references with "issue" references, removes the feedback command row and paragraph from the README, removes the "Submit feedback" step from quick-start docs, and adds the patch changeset entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • TanStack/intent#156: Modifies the same runListCommand output flow in packages/intent/src/commands/list.ts, surfacing notices and adjusting related behavior — directly adjacent to the feedback guidance block removed in this PR.

Poem

🐇 Hippity-hoppity, feedback's away,
No more collection or skill to display!
The feedback.ts file has hopped down the drain,
Types, tests, and meta-skill — none shall remain.
Issues speak louder than old survey forms,
A cleaner intent package now warms the burrow! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove unused feedback feature' clearly and concisely describes the main change—deletion of feedback-related code, APIs, and documentation from the package.
Description check ✅ Passed The PR description fully explains what was removed (feedback implementation, exports, types, tests, meta-skill) and what was preserved (historical changelog), aligning with the template's requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-feedback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloud Bot commented Jun 16, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit afd230a

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded <1s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-16 04:55:57 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/TanStack/intent/@tanstack/intent@165

commit: afd230a

@codspeed-hq

codspeed-hq Bot commented Jun 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing remove-feedback (afd230a) with main (d5d9181)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (6435257) during the generation of this report, so d5d9181 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@LadyBluenotes LadyBluenotes merged commit 2676302 into main Jun 16, 2026
11 of 12 checks passed
@LadyBluenotes LadyBluenotes deleted the remove-feedback branch June 16, 2026 05:06
@github-actions github-actions Bot mentioned this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants