chore: add activity-coverage dimension to gap-analysis skill#744
Merged
Conversation
Adds a sixth audit dimension (and an `activities` invocation scope) that diffs which of the 7 core activity kinds each provider ships an adapter for against what upstream offers, with a provider×activity grid in the report template. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughThis PR documents a new "Activity coverage" dimension (Dimension 6) for the gap-analysis skill: it defines seven adapter activity kinds, maps adapter filenames to activity kinds, prescribes an audit checklist for provider×activity coverage, adjusts orchestrator/subagent responsibilities, and updates the report template. ChangesActivity Coverage Dimension for Gap-Analysis Skill
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Changeset Version Preview6 package(s) bumped directly, 25 bumped as dependents. 🟥 Major bumps
🟨 Minor bumps
🟩 Patch bumps
|
|
View your CI Pipeline Execution ↗ for commit 030a6cb
☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-anthropic
@tanstack/ai-client
@tanstack/ai-code-mode
@tanstack/ai-code-mode-skills
@tanstack/ai-devtools-core
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-groq
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-mcp
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-openrouter
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-utils
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.claude/skills/gap-analysis/references/report-template.md (1)
6-11:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd missing
activitiesscope to the list.The scope list is incomplete.
SKILL.mdline 60-61 definesactivitiesas a valid scope (e.g.,.agent/gap-analysis/YYYY-MM-DD-activities.md), but this template omits it.📝 Proposed fix
- `<provider>` — e.g. `openai` - `feature-<feature>` — e.g. `feature-tts` - `models` +- `activities` - `all`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/gap-analysis/references/report-template.md around lines 6 - 11, Update the `<scope>` enumeration in the report-template to include the missing `activities` scope; specifically add `activities` (matching SKILL.md's example usage like `.agent/gap-analysis/YYYY-MM-DD-activities.md`) alongside `provider`, `feature-<feature>`, `models`, and `all` so the template and SKILL.md remain consistent.
🧹 Nitpick comments (1)
.claude/skills/gap-analysis/references/report-template.md (1)
98-118: ⚡ Quick winConsider clarifying the report section scope applicability.
The activity coverage section will appear in reports for
activitiesscope and--allscope, but not for single-provider orfeatureormodelsscopes. Consider adding a note (similar to line 83's "Per dimension 5") that explicitly states when this section should be included, to help maintainers know when to drop it per line 13's guidance.📝 Suggested addition
## Activity coverage -> Per dimension 6 in audit-checklist.md. Which of the 7 core activity kinds +> Per dimension 6 in audit-checklist.md (included in `activities` and `--all` scopes only). Which of the 7 core activity kinds🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/gap-analysis/references/report-template.md around lines 98 - 118, The "Activity coverage" section (heading "Activity coverage" and the "Per dimension 6" reference) should explicitly state when it is included in generated reports: add a short note under the heading (similar to the existing "Per dimension 5" note on the template) clarifying that this section is shown for the "activities" scope and when "--all" is used, and that it should be omitted for "single-provider", "feature", and "models" scopes; update the template text immediately above the table so maintainers know when to keep or drop this section.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/gap-analysis/references/report-template.md:
- Line 109: Update the legend line that currently reads "Legend: ✅ adapter
shipped · ❌ upstream offers it, no adapter (gap) · — upstream doesn't offer it
(by design)." so it matches the audit checklist's notation by replacing the em
dash item with the "❌-by-design" token used in audit-checklist.md; ensure the
legend contains "❌-by-design" (or the exact token used in audit-checklist.md)
instead of "— upstream doesn't offer it (by design)" so both documents use the
same notation.
---
Outside diff comments:
In @.claude/skills/gap-analysis/references/report-template.md:
- Around line 6-11: Update the `<scope>` enumeration in the report-template to
include the missing `activities` scope; specifically add `activities` (matching
SKILL.md's example usage like `.agent/gap-analysis/YYYY-MM-DD-activities.md`)
alongside `provider`, `feature-<feature>`, `models`, and `all` so the template
and SKILL.md remain consistent.
---
Nitpick comments:
In @.claude/skills/gap-analysis/references/report-template.md:
- Around line 98-118: The "Activity coverage" section (heading "Activity
coverage" and the "Per dimension 6" reference) should explicitly state when it
is included in generated reports: add a short note under the heading (similar to
the existing "Per dimension 5" note on the template) clarifying that this
section is shown for the "activities" scope and when "--all" is used, and that
it should be omitted for "single-provider", "feature", and "models" scopes;
update the template text immediately above the table so maintainers know when to
keep or drop this section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3a2cd18b-baf3-489c-ad46-6e517792320a
📒 Files selected for processing (3)
.claude/skills/gap-analysis/SKILL.md.claude/skills/gap-analysis/references/audit-checklist.md.claude/skills/gap-analysis/references/report-template.md
| | -------- | :--: | :-------: | :---: | :---: | :---: | :-: | :-----------: | | ||
| | {{provider}} | {{✅/❌/—}} | … | … | … | … | … | … | | ||
|
|
||
| Legend: ✅ adapter shipped · ❌ upstream offers it, no adapter (gap) · — upstream doesn't offer it (by design). |
Contributor
There was a problem hiding this comment.
Align by-design notation with audit-checklist.md.
The legend uses "—" (em dash) for "upstream doesn't offer it (by design)", but audit-checklist.md lines 249 and 271 use "❌-by-design" notation for the same concept. These should match to avoid confusion when following the checklist to generate the report.
📝 Suggested fix
-Legend: ✅ adapter shipped · ❌ upstream offers it, no adapter (gap) · — upstream doesn't offer it (by design).
+Legend: ✅ adapter shipped · ❌ upstream offers it, no adapter (gap) · ❌-by-design upstream doesn't offer it.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Legend: ✅ adapter shipped · ❌ upstream offers it, no adapter (gap) · — upstream doesn't offer it (by design). | |
| Legend: ✅ adapter shipped · ❌ upstream offers it, no adapter (gap) · ❌-by-design upstream doesn't offer it. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/skills/gap-analysis/references/report-template.md at line 109,
Update the legend line that currently reads "Legend: ✅ adapter shipped · ❌
upstream offers it, no adapter (gap) · — upstream doesn't offer it (by design)."
so it matches the audit checklist's notation by replacing the em dash item with
the "❌-by-design" token used in audit-checklist.md; ensure the legend contains
"❌-by-design" (or the exact token used in audit-checklist.md) instead of "—
upstream doesn't offer it (by design)" so both documents use the same notation.
AlemTuzlak
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Updates the
gap-analysismaintainer skill (.claude/skills/gap-analysis/) with a new activity coverage audit dimension:activitiesinvocation scope: a fast mechanical diff of which of the 7 core activity kinds (text,summarize,image,audio,video,tts,transcription— theAdapterKindunion inpackages/ai/src/activities/index.ts) each provider ships an adapter for, vs. what upstream offers.--allsweep rolls dimension 6 in; subagent dispatch prompt updated to skip it (orchestrator builds the grid).Skill-only change — no source code, docs pages, or published packages touched.
✅ Checklist
pnpm run test:pr. (N/A — markdown-only skill change, no code affected)🚀 Release Impact
🤖 Generated with Claude Code
Summary by CodeRabbit