Skip to content

chore: remove directories creation - #100

Merged
ThibaultFy merged 5 commits into
mainfrom
chore/stop-trying-to-create-directories
Jul 4, 2024
Merged

chore: remove directories creation#100
ThibaultFy merged 5 commits into
mainfrom
chore/stop-trying-to-create-directories

Conversation

@ThibaultFy

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy

Copy link
Copy Markdown
Member Author

/e2e --tests substrafl, mnist, camelyon

@Owlfred

Owlfred commented Jul 3, 2024

Copy link
Copy Markdown

End to end tests: ✔️ SUCCESS

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy

Copy link
Copy Markdown
Member Author

/e2e --tests substrafl, mnist, camelyon

@Owlfred

Owlfred commented Jul 3, 2024

Copy link
Copy Markdown

End to end tests: ✔️ SUCCESS

@ThibaultFy
ThibaultFy marked this pull request as ready for review July 3, 2024 14:41
@ThibaultFy
ThibaultFy requested a review from a team as a code owner July 3, 2024 14:41
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>

@thbcmlowk thbcmlowk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did we test that both in local and docker mode?

@ThibaultFy

Copy link
Copy Markdown
Member Author

Did we test both in local and docker mode?

Yes I did :)

@thbcmlowk thbcmlowk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ThibaultFy
ThibaultFy merged commit 35d32ee into main Jul 4, 2024
@ThibaultFy
ThibaultFy deleted the chore/stop-trying-to-create-directories branch July 4, 2024 11:59
@thbcmlowk

Copy link
Copy Markdown
Contributor

/e2e --tests=mnist,camelyon

@Owlfred

Owlfred commented Jul 15, 2024

Copy link
Copy Markdown

End to end tests: ✔️ SUCCESS

Congratulations!

@thbcmlowk
thbcmlowk restored the chore/stop-trying-to-create-directories branch July 15, 2024 14:11
@thbcmlowk
thbcmlowk deleted the chore/stop-trying-to-create-directories branch September 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants