[GTMBot] Restructure dark mode docs#140
Closed
izhan wants to merge 1 commit into
Closed
Conversation
…per guide to toggle - New: learn/theme/dark-mode.mdx — designer-focused dark mode docs (adding, previewing, removing) - Rewrite: guides/dark-mode.mdx — narrowed to dark mode toggle implementation only - Update: customizing-theme.mdx — add dark mode subsection under Colors - Update: exporting-theme.mdx — fix dark mode cross-link to Learn article - Update: docs.json — add dark-mode to Learn > Theme nav
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Restructures the dark mode documentation based on Irvin's feedback. The previous
guides/dark-mode.mdxwas a single bloated article that mixed designer and developer concerns, had a gibberish outline ("enable dark mode" appeared twice), no cross-links, and wasn't discoverable from Learn Subframe where users actually look.Changes
New:
learn/theme/dark-mode.mdxDesigner-focused dark mode article under Learn > Theme. Covers adding dark mode, previewing light/dark, and removing dark mode. Follows the structure of sibling articles (customizing-theme, importing-tokens, etc.).
Rewritten:
guides/dark-mode.mdx→ "Dark mode toggle"Narrowed from a catch-all dark mode article to a focused developer guide on wiring up the class toggle (next-themes for Next.js, context provider for Vite/React). Links back to the Learn article for the design side.
Updated:
customizing-theme.mdxAdded "Dark mode" subsection under Colors (H3), since that's where the feature lives in the UI. Cross-links to both the Learn article and the developer guide.
Updated:
exporting-theme.mdxFixed dark mode cross-link to point to the new Learn article instead of the old developer guide.
Updated:
docs.jsonAdded
learn/theme/dark-modeto the Learn > Theme nav group.TODOs
learn/theme/dark-mode.mdx(marked with{/* TODO */})