Corrected accessibility text scaling - #1259
Merged
Merged
Conversation
Sub6Resources
requested changes
May 12, 2023
Sub6Resources
left a comment
Sub6Resources
left a comment
Owner
There was a problem hiding this comment.
There are a lot of whitespace changes here. I'm assuming this is because you have your formatter's line width set off of the default. Could you reformat the code with the default dart line width using dart format with the --line-length=80 tag set?
The line width of 80 is an ongoing debate: dart-lang/dart_style#833, but flutter_html is just using the current standard (however frustrating it may be).
Contributor
Author
|
Sorry for messing up the formatting, should be ok now. |
Sub6Resources
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to Text.rich form RichText to have textscalefactor applied.
However textscalefactor is applied on each Text.rich recursively, so only apply it to toplevel.