[bidi][java] Add test to add a cookie in a user context

[pujagani]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Tests

---

Description

• Added a new test canGetCookieInAUserContext to validate cookie handling in user contexts.

• Implemented user context creation and cookie operations using Browser and Storage modules.

• Verified partition keys and cookie values for user-specific contexts.

• Ensured proper cleanup and context switching in the test.

---

Changes walkthrough 📝

Relevant files

Tests

StorageCommandsTest.java Added test for user context cookie handling                            java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java Added a new test canGetCookieInAUserContext. Utilized Browser module to create user contexts. Implemented cookie setting and retrieval with partition descriptors. Verified partition keys and ensured context-specific cookie isolation. +54/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Cleanup The test creates a user context but doesn't explicitly clean it up after the test. Consider adding cleanup code to ensure the user context is properly disposed of after the test completes. String userContext = browser.createUserContext(); Error Handling The test doesn't include any error handling for potential failures when creating contexts or switching between windows. Consider adding try-catch blocks or assertions to verify operations succeed. driver.switchTo().window(context.getId());

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add user context cleanup The test should clean up the created user context after the test completes to prevent resource leaks. Add code to delete the user context in a try-finally block or at the end of the test. java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java [130-131] String userContext = browser.createUserContext(); String windowHandle = driver.getWindowHandle(); +try { Apply this suggestion Suggestion importance[1-10]: 8 __ Why: This suggestion addresses an important resource management issue. Not cleaning up user contexts could lead to resource leaks during test execution, especially when running multiple tests. The suggestion correctly identifies the need for proper cleanup.	Medium
	Close browsing context The test should close the newly created browsing context after it's no longer needed to prevent resource leaks. Add code to close the context after switching back to the original window. java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java [166-169] driver.switchTo().window(windowHandle); +context.close(); PartitionDescriptor browsingContextPartitionDescriptor = new BrowsingContextPartitionDescriptor(windowHandle); Apply this suggestion Suggestion importance[1-10]: 8 __ Why: This suggestion correctly identifies a resource leak where the newly created browsing context is not properly closed after use. Failing to close contexts can lead to resource exhaustion when running multiple tests, making this an important fix for test stability.	Medium
Learned best practice	Add null validation for critical values returned from API calls to ensure clear failure messages The test creates a user context and uses it without validating that it's not null. Since this is a critical part of the test, you should add a null check for the userContext value returned from browser.createUserContext() to ensure the test fails clearly if user context creation fails. java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java [130-136] String userContext = browser.createUserContext(); +if (userContext == null) { + throw new IllegalStateException("Failed to create user context"); +} String windowHandle = driver.getWindowHandle(); String key = generateUniqueKey(); String value = "set"; PartitionDescriptor descriptor = new StorageKeyPartitionDescriptor().userContext(userContext); Apply this suggestion Suggestion importance[1-10]: 6	Low
More